Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Octave #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gllmflndn
Copy link

These changes were necessary for compatibility with GNU Octave.

Bug reports have been submitted for the following:
fopen(-1)
and
strmatch('a',[])
which should return without error but code is cleaner anyway by not relying on these corner cases.

@agramfort
Copy link
Member

can someone test that it still works with matlab?

ideally it would be nice to have travis running octave tests if their are users of this code.

@gllmflndn
Copy link
Author

It would indeed be great to have Travis testing with Octave 4.2. I could only run two of the five tests because of the requirement to have access to the dataset from MNE_SAMPLE_DATASET_PATH.

@gllmflndn
Copy link
Author

Also, @agramfort and @robertoostenveld, how is this repository synchronised with https://github.com/fieldtrip/fieldtrip/tree/master/external/mne ? Could FT use git submodules?

@robertoostenveld
Copy link

I only vaguely know git submodules and never used it. Right now I (or someone else) copies the mne-matlab code into the FT repo and commits.

@agramfort
Copy link
Member

agramfort commented Nov 25, 2016 via email

@larsoner
Copy link
Member

larsoner commented Nov 8, 2024

ideally it would be nice to have travis running octave tests if their are users of this code.

We now have some basic unit tests, so I've fixed the merge conflict. I'll merge once CIs come back green, thanks in advance (and apologies for dropping the ball on this for years)!

@larsoner
Copy link
Member

larsoner commented Nov 8, 2024

... actually it looks like this does break a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants