Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear stale line mark state #1268

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Clear stale line mark state #1268

merged 2 commits into from
Jan 29, 2025

Conversation

tianleq
Copy link
Collaborator

@tianleq tianleq commented Jan 28, 2025

image
image
image
Overall, this fix does not incur significant overhead

@tianleq tianleq requested a review from qinsoon January 28, 2025 23:56
qinsoon
qinsoon approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@qinsoon
Copy link
Member

qinsoon commented Jan 29, 2025

The missing import needs to be fixed though.

@tianleq
Copy link
Collaborator Author

tianleq commented Jan 29, 2025

The missing import needs to be fixed though.

Yes, fixed

@qinsoon qinsoon added this pull request to the merge queue Jan 29, 2025
Merged via the queue into mmtk:master with commit 054feef Jan 29, 2025
33 checks passed
@tianleq tianleq mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianleq @qinsoon