Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build error on Windows 10 by exporting zlibstatic alongside Ptex_static #472

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

he-yulong
Copy link
Contributor

@he-yulong he-yulong commented Dec 29, 2024

The related open issue: #467

  • Adds a post-configuration step that explicitly installs zlibstatic into the Ptex export set.
  • Prevents "target not in any export set" errors during the installation stage.
  • Leaves the existing Ptex submodule files unmodified, preserving upstream compatibility.
  • Verified on Windows 10 with Visual Studio 2022.

… Ptex_static.

* Adds a post-configuration step that explicitly installs `zlibstatic` into the `Ptex` export set.
* Prevents "target not in any export set" errors during the installation stage.
* Leaves the existing Ptex submodule files unmodified, preserving upstream compatibility.
* Verified on Windows 10 with Visual Studio 2022.
@mmp mmp merged commit fb5988a into mmp:master Jan 30, 2025
@mmp
Copy link
Owner

mmp commented Jan 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants