Merge pull request #5 from mmoreram/feature/refactoring-best-practices

Some refactoring for using Best Practices
mmoreram · Oct 29, 2014 · c7d3318 · c7d3318
2 parents 0d8ac05 + 1913430
commit c7d3318
Show file tree

Hide file tree

Showing 29 changed files with 217 additions and 26 deletions.
diff --git a/.formatter.yml b/.formatter.yml
@@ -5,7 +5,7 @@ use-sort:
     sort-type: alph
     sort-direction: asc
 header: |
-    /**
+    /*
      * This file is part of the Extractor package.
      *
      * For the full copyright and license information, please view the LICENSE

diff --git a/composer.json b/composer.json
@@ -20,7 +20,9 @@
         "ext-zip": "For usage of Zip adapter"
     },
     "autoload": {
-        "psr-4": {"Mmoreram\\Extractor\\": ""}
+        "psr-4": {
+            "Mmoreram\\Extractor\\": "src/Extractor"
+        }
     },
     "minimum-stability": "stable",
     "extra": {

diff --git a/...er/Abstracts/AbstractExtractorAdapter.php → ...er/Abstracts/AbstractExtractorAdapter.php b/...er/Abstracts/AbstractExtractorAdapter.php → ...er/Abstracts/AbstractExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/DummyExtractorAdapter.php → ...tractor/Adapter/DummyExtractorAdapter.php b/Adapter/DummyExtractorAdapter.php → ...tractor/Adapter/DummyExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/.../Interfaces/ExtractorAdapterInterface.php → .../Interfaces/ExtractorAdapterInterface.php b/.../Interfaces/ExtractorAdapterInterface.php → .../Interfaces/ExtractorAdapterInterface.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/PharExtractorAdapter.php → ...xtractor/Adapter/PharExtractorAdapter.php b/Adapter/PharExtractorAdapter.php → ...xtractor/Adapter/PharExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/RarExtractorAdapter.php → ...Extractor/Adapter/RarExtractorAdapter.php b/Adapter/RarExtractorAdapter.php → ...Extractor/Adapter/RarExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/TarBz2ExtractorAdapter.php → ...ractor/Adapter/TarBz2ExtractorAdapter.php b/Adapter/TarBz2ExtractorAdapter.php → ...ractor/Adapter/TarBz2ExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/TarExtractorAdapter.php → ...Extractor/Adapter/TarExtractorAdapter.php b/Adapter/TarExtractorAdapter.php → ...Extractor/Adapter/TarExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/TarGzExtractorAdapter.php → ...tractor/Adapter/TarGzExtractorAdapter.php b/Adapter/TarGzExtractorAdapter.php → ...tractor/Adapter/TarGzExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Adapter/ZipExtractorAdapter.php → ...Extractor/Adapter/ZipExtractorAdapter.php b/Adapter/ZipExtractorAdapter.php → ...Extractor/Adapter/ZipExtractorAdapter.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Exception/AdapterNotAvailableException.php → ...xception/AdapterNotAvailableException.php b/Exception/AdapterNotAvailableException.php → ...xception/AdapterNotAvailableException.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Exception/ExtensionNotSupportedException.php → ...eption/ExtensionNotSupportedException.php b/Exception/ExtensionNotSupportedException.php → ...eption/ExtensionNotSupportedException.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Exception/FileNotFoundException.php → ...actor/Exception/FileNotFoundException.php b/Exception/FileNotFoundException.php → ...actor/Exception/FileNotFoundException.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Extractor.php → src/Extractor/Extractor.php b/Extractor.php → src/Extractor/Extractor.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Filesystem/Interfaces/DirectoryInterface.php → ...esystem/Interfaces/DirectoryInterface.php b/Filesystem/Interfaces/DirectoryInterface.php → ...esystem/Interfaces/DirectoryInterface.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Filesystem/SpecificDirectory.php → ...xtractor/Filesystem/SpecificDirectory.php b/Filesystem/SpecificDirectory.php → ...xtractor/Filesystem/SpecificDirectory.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/Filesystem/TemporaryDirectory.php → ...tractor/Filesystem/TemporaryDirectory.php b/Filesystem/TemporaryDirectory.php → ...tractor/Filesystem/TemporaryDirectory.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/src/Extractor/Resolver/ExtensionResolver.php b/src/Extractor/Resolver/ExtensionResolver.php
@@ -0,0 +1,69 @@
+<?php
+
+/*
+ * This file is part of the Extractor package.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * Feel free to edit as you please, and have fun.
+ *
+ * @author Marc Morera <[email protected]>
+ */
+
+namespace Mmoreram\Extractor\Resolver;
+
+use Mmoreram\Extractor\Exception\ExtensionNotSupportedException;
+use Mmoreram\Extractor\Resolver\Interfaces\ExtensionResolverInterface;
+
+/**
+ * Class ExtensionResolver
+ */
+class ExtensionResolver implements ExtensionResolverInterface
+{
+    /**
+     * Return a extractor adapter namespace given an extension
+     *
+     * @param string $fileExtension File extension
+     *
+     * @return string Adapter namespace
+     *
+     * @throws ExtensionNotSupportedException Exception not found
+     */
+    public function getAdapterNamespaceGivenExtension($fileExtension)
+    {
+        $adapterNamespace = '\Mmoreram\Extractor\Adapter\\';
+
+        switch ($fileExtension) {
+
+            case 'zip':
+                $adapterNamespace .= 'ZipExtractorAdapter';
+                break;
+
+            case 'rar':
+                $adapterNamespace .= 'RarExtractorAdapter';
+                break;
+
+            case 'phar':
+                $adapterNamespace .= 'PharExtractorAdapter';
+                break;
+
+            case 'tar':
+                $adapterNamespace .= 'TarExtractorAdapter';
+                break;
+
+            case 'gz':
+                $adapterNamespace .= 'TarGzExtractorAdapter';
+                break;
+
+            case 'bz2':
+                $adapterNamespace .= 'TarBz2ExtractorAdapter';
+                break;
+
+            default:
+                throw new ExtensionNotSupportedException($fileExtension);
+        }
+
+        return $adapterNamespace;
+    }
+}
diff --git a/src/Extractor/Resolver/Interfaces/ExtensionResolverInterface.php b/src/Extractor/Resolver/Interfaces/ExtensionResolverInterface.php
@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of the Extractor package.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * Feel free to edit as you please, and have fun.
+ *
+ * @author Marc Morera <[email protected]>
+ */
+
+namespace Mmoreram\Extractor\Resolver\Interfaces;
+
+use Mmoreram\Extractor\Exception\ExtensionNotSupportedException;
+
+/**
+ * Interface ExtensionResolverInterface
+ */
+interface ExtensionResolverInterface
+{
+    /**
+     * Return a extractor adapter namespace given an extension
+     *
+     * @param string $fileExtension File extension
+     *
+     * @return string Adapter namespace
+     *
+     * @throws ExtensionNotSupportedException Exception not found
+     */
+    public function getAdapterNamespaceGivenExtension($fileExtension);
+}
diff --git a/tests/Adapter/PharExtractorAdapterTest.php b/tests/Adapter/PharExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Adapter/RarExtractorAdapterTest.php b/tests/Adapter/RarExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Adapter/TarBz2ExtractorAdapterTest.php b/tests/Adapter/TarBz2ExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Adapter/TarExtractorAdapterTest.php b/tests/Adapter/TarExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Adapter/TarGzExtractorAdapterTest.php b/tests/Adapter/TarGzExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Adapter/ZipExtractorAdapterTest.php b/tests/Adapter/ZipExtractorAdapterTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/ExtractorTest.php b/tests/ExtractorTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE

diff --git a/tests/Filesystem/SpecificDirectoryTest.php b/tests/Filesystem/SpecificDirectoryTest.php
@@ -1,6 +1,6 @@
 <?php
 
-/**
+/*
  * This file is part of the Extractor package.
  *
  * For the full copyright and license information, please view the LICENSE