line segment #19
Open
line segment #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenigsley
suggested changes
Nov 6, 2021
| def length | ||
| # Your code goes here... | ||
| # REQUIREMENT: use lazy evaluation | ||
| begins_at.distance ends_at |
There was a problem hiding this comment.
The distance method uses the square root function under the hood. Also the length won`t be changed because the points are fixed. It is better to store the length as an instance variable and use lazy initialization.
def length
@length ||= begins_at.distance ends_at
end| def to_straight_line | ||
| a = ends_at.y - begins_at.y | ||
| b = begins_at.x - ends_at.x | ||
| c = -begins_at.x * ends_at.y + begins_at.y * ends_at.x |
There was a problem hiding this comment.
Please, add tests for to_straight_line method.
| StraightLine.new(a, b, c) | ||
| end | ||
|
|
||
| def check_is_a_point(x) |
There was a problem hiding this comment.
This utility method should be private.
|
Please, add tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented line_segment class with its basic method, made tests for methods
Solution for issue #9