Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming instances of http-clients, http-servers, and context-in-http-servers to be consistent with examples. #549

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Renaming instances of http-clients, http-servers, and context-in-http-servers to be consistent with examples. #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87c9b5
renaming instances of http-clients and http-servers to be singular.
bustosalex1 Aug 11, 2024
8ea6adb
reverting changes relating to http-client and http-server
bustosalex1 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/context/context.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Run the server in the background.
$ go run context-in-http-servers.go &
$ go run context.go &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is worthwhile, but the http-server(s) http-client(s) - I prefer to keep as is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. Just reverted those changes.


# Simulate a client request to `/hello`, hitting
# Ctrl+C shortly after starting to signal
Expand Down
2 changes: 1 addition & 1 deletion public/context
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading