Rewrite Choice step to make it usable from mlrun #537
Conversation
| self.to(default) | ||
| self._default = default | ||
| def _init(self, **kwargs): | ||
| super()._init() |
There was a problem hiding this comment.
Just to make sure it is not an error: before the change the kwargs were sent at the Flow init so I would expect to see super().__init__(**kwargs) unless it is redundant. I think the outlets param should be passed here?
There was a problem hiding this comment.
Thanks, the **kwargs need to be removed. There's no kwargs in _init(). Note that _init is unrelated to __init__.
storey/flow.py
Outdated
| # TODO: hacky way of supporting mlrun preview, which replaces targets with a DFTarget | ||
| self._passthrough_for_preview = list(self._name_to_outlet) == ["dataframe"] | ||
|
|
||
| def select_outlets(self, event): |
There was a problem hiding this comment.
I would add a type hint and also in the doc string mention that the selected outlets should be returned in a list of strings - the outlet names.
| def select_outlets(self, event): | |
| def select_outlets(self, event) -> List[str]: |
| if self._passthrough_for_preview: | ||
| outlet = self._name_to_outlet["dataframe"] | ||
| outlets.append(outlet) |
There was a problem hiding this comment.
add a TODO here as well to remember to delete this "hack"
There was a problem hiding this comment.
I don't really want to duplicate the TODO that's already on the attribute definition.
ML-7818