fix NOTEs

mlr-org · Jan 6, 2025 · 46b4ddd · 46b4ddd
1 parent 3cbc8e6
commit 46b4ddd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -37,7 +37,6 @@ Imports:
     ggplot2,
     mlr3misc (>= 0.7.0),
     mlr3pipelines (>= 0.7.0),
-    mlr3viz,
     paradox (>= 1.0.0),
     R6,
     Rcpp (>= 1.0.4),
@@ -50,6 +49,7 @@ Suggests:
     lgr,
     lifecycle,
     mlr3learners,
+    mlr3viz,
     pammtools,
     param6 (>= 0.2.4),
     polspline,

diff --git a/R/MeasureSurvICI.R b/R/MeasureSurvICI.R
@@ -119,7 +119,7 @@ MeasureSurvICI = R6Class("MeasureSurvICI",
       pv = self$param_set$values
 
       # time point for calibration
-      time = pv$time %??% median(times)
+      time = pv$time %??% stats::median(times)
 
       # get cdf at the specified time point
       extend_times_cdf = getFromNamespace("C_Vec_WeightedDiscreteCdf", ns = "distr6")

diff --git a/R/autoplot.R b/R/autoplot.R
@@ -353,6 +353,7 @@ autoplot.PredictionSurv = function(object, type = "calib",
       cll_grid = log(-log(1 - cdf_grid))
 
       smoothed_cdf_grid = polspline::phare(q = time, cov = cll_grid, fit = hare_fit)
+      pred = obs = NULL
       data = data.table(pred = cdf_grid, obs = smoothed_cdf_grid)
 
       ggplot(data, aes(x = pred, y = obs)) +

diff --git a/man/mlr3proba-package.Rd b/man/mlr3proba-package.Rd