WIP: Efficient external file watching #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the feature for typescript-plugin-asset to watch files using its own glob. - Use the include/exclude option in tsconfig.json instead. - Only tsserver can watch files.
mizdra
commented
Oct 14, 2023
| "react-dom": "18.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "typescript": "^5.3.0-dev.20231014" |
There was a problem hiding this comment.
I have to wait for the merge until the vscode release bundled with typescript 5.3.
mizdra
added
Type: Change
mizdra
commented
Oct 14, 2023
| ### `exclude` | ||
|
|
||
| Glob pattern of assets to exclude. `@mizdra/typescript-plugin-asset` does not complete import statements for assets matching this pattern. | ||
|
|
There was a problem hiding this comment.
include/exclude options are obsoluted. The users should use https://www.typescriptlang.org/tsconfig#include or https://www.typescriptlang.org/tsconfig#exclude instead.
This is breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: vuejs/language-tools#3649, microsoft/TypeScript#56047
Until now, it was not possible to watch asset file additions with tsserver alone. Therefore, typescript-plugin-asset used
ts.sys.watchDirectoryto watch asset file additions on its own.Normally, watching the file system is expensive. Therefore, it is not a good idea for both tsserver and plugin to watch the file system. Only one of them should do the watching.
In this PR, watching the asset files is also left to the tsserver side and the watching in the plugin is removed.