fix(markdown-renderer): preserve list margin spacing #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
commented
Apr 22, 2024
nijel
force-pushed
the
preserve-list-spacing
branch
from
6a27e2f to
6921bf2
Compare
|
@nijel, thanks for your PR! I've found some small details and fixed them right away - can you please review my commit and squash it to your original commit if you find it OK? |
The extra spacing can be before of after leader, so try to preserve it on both positions. Fixes miyuchina#213
nijel
force-pushed
the
preserve-list-spacing
branch
from
e53b6fd to
207b675
Compare
|
Looks good, I've just squashed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra spacing can be before of after leader, so try to preserve it on both positions.
Fixes #213