Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QML #93

Closed
wants to merge 1 commit into from
Closed

feat: add QML #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,16 @@ jobs:
portmidi
protobuf
pthreads
qt5compat
qt5compat[qml]
qtbase
qtdeclarative
qtsvg
qttranslations
qtkeychain-qt6
qt3d[qml]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only need the QML feature? Than qt3d[core,qml] could be used instead, which doesn't build the optional default-features of this VCPKG port.
The build time of qt3d was 39 minutes in the last Windows CI run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure we do, I need to test without it, but I suspected this could be related to QtQuick.Scene3D used there but I haven't been able to test on Windows as I seem to get a crash when I try to open a device (could be my VM)

qtquick3d
qtquick3dphysics
qtquickcontrols2
rubberband
soundtouch
taglib
Expand Down