[qt5-base] Upgrade to Qt 5.15.11 #91
Conversation
This fixes a configure issue on Xcode 15/macOS Sonoma.
|
The patch qmake_xcode15.patch seems to be the only difference - and is included in the upstream version. Why do we need an overlay here? |
|
We still need all of the cross-compilation machinery since upstream Qt 5 doesn't support that well (or didn't want to include our |
|
microsoft#28835 was the upstream issue, not sure if that still applies though |
|
This probably also needs some more testing... my native Qt 5.15.11 build of Mixxx seems to work mostly fine, except for the EQ knobs, which don't work (neither affecting the audio nor the waveform). |
|
Perhaps, given that the 2.4 release is upcoming, it's not really worth investing a lot of time into this? While I would love to be able to build 2.4 environments on Sonoma to diagnose 2.4 issues, maybe this is too risky to integrate after all? Especially considering that the 5.12 CI build still runs flawlessly and that this only affects developers who wish to build environments locally on the most recent macOS. Feeling a bit torn here, ideally we would just find the issue that prevents 5.12 from building (see #87), but digging through a humongous diff between Qt versions is no fun either... |
|
Yes, let's postpone this, or even skip it and traight advence to qt6. I see a good chance to just fix the issue itself. |
|
By the way, the EQ issue on my machine was only an artifact of switching between Mixxx versions, the solution being to simply delete the But I agree, let's revisit this once we've shipped 2.4.0. |
|
I think we can close this is favour of #87 |
As suggested by @JoergAtGithub in #90 (comment), this branch provides an experimental Qt 5.15.11 environment.