Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[soundtouch] Update SHA512 checksum #104

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Nov 30, 2023

This is a cherry-pick of microsoft#35269, which updates the checksum of soundtouch as per #92 (comment).

@fwcd fwcd requested a review from daschuer November 30, 2023 00:53
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for taking care.

Normally we are follow the strategy to merge all changes from upstream before beta testing has started and apply only required cherry picks during beta and after release. Now we have the situation that Qt 6.6.0 fails to build, so we have also a kind of freeze situations here, see #94
So I think this cherry pick is OK and we should release Mixxx 2.5 with Qt 6.5.3 LTS

@daschuer daschuer merged commit a52e10e into mixxxdj:2.5 Nov 30, 2023
2 checks passed
@fwcd fwcd deleted the cherry-pick-soundtouch branch November 30, 2023 11:43
@fwcd
Copy link
Member Author

fwcd commented Nov 30, 2023

Qt 6.6.0 fails to build

Hm that's strange, do we have an upstream bug for this? microsoft#35396 looks somewhat similar. Would of course be nice if we would not have to vendor Qt this time again.

By the way, could you merge 2.5 -> 2.5-rel?

@daschuer
Copy link
Member

I have not found the time to investigate and report it properly. For now I think it is good to stick with a LTS Qt version for the 2.5 release. My current priority is to get 2.4 released. It is really anoying to be 4 month behind the original release date.

I take care with the merge now.

@fwcd
Copy link
Member Author

fwcd commented Nov 30, 2023

Totally understandable, no worries, was just curious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants