Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding controls for BPM operations (so we can create shortcuts) #13025

Closed
wants to merge 2 commits into from
Closed

adding controls for BPM operations (so we can create shortcuts) #13025

wants to merge 2 commits into from

Conversation

FrankwaP
Copy link
Contributor

Hi!

My objective is to accelerate the track preparations by using keyboard shortcuts.

The basics are:

  • adjusting the BPM (x1/2, …, x2)
  • translating the beatgrid
  • locking/unlocking the BPM

So far it's only possible to create shortcuts for "translating the beatgrid", using beats_translate_earlier, beats_translate_later, and beats_translate_curpos controls.

This PR is about creating controls for "adjusting the BPM (x1/2, …, x2)", so it's possible to create shortcuts.
BTW I've found this old post asking for such feature: https://mixxx.discourse.group/t/double-halve-bpm-with-keyboard/13333

Side note:
I play music with breakbeats like dnb, jungle, breakcore… and I think these are among the trickiest BPM to guess.
Yet, I only use x3/2 and x2 BPM adjustment and I'm wondering if the other adjustments are actually useful at all. Were there requests for these or is it a YAGNI case?

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Mar 30, 2024

Hi! Keyboard shortcuts for this would be handy. I made a PR recently for doing it by MIDI #12934. I guess they shouldn't conflict, though possibly there might be ways to make them align, in text used maybe or such. Or maybe at a deeper level. (I haven't checked your code yet, just browsing the latest activity of the project).

Big up bass n breaks n fast paces!

Edit: yeah, looks like they're is a bit of a clash, but it can be made to work. I'll leave saying what to someone who knows the project better, I'm at the newb end of things here.

@FrankwaP
Copy link
Contributor Author

FrankwaP commented Mar 30, 2024

@mxmilkiib Well it's definitely a clash if not a complete duplicate :-p

My bad as yours is 4 days earlier and I actually saw it… but since I hadn't put my nose into the code at that time, that did not make much sense to me.

I definitely looks like the best choice is to cancel my PR.

@FrankwaP
Copy link
Contributor Author

FrankwaP commented Mar 30, 2024

Keyboard shortcuts for this would be handy.

In your case (using the semantic of your PR), you can add such lines into a custom keyboard mapping:


[Channel1]
beats_set_halve Shift+Ctrl+F1
...
beats_set_double Shift+Ctrl+F6

[Channel2]
beats_set_halve Shift+Ctrl+F7
...
beats_set_double Shift+Ctrl+F12

Big up bass n breaks n fast paces!

Big up the drums packed 174 BPM tracks that are detected as 116 BPM :-D

@mxmilkiib
Copy link
Contributor

Stars yeah! I sat down to DJ at 160 after finishing a previous PR, and every second track was like 96, 106, or 120, n sod reaching for the mouse every time.

Just need to map it all to my Launchpad now.. (keep distracting my AuDHD self though from my evening flow, like, got a new qmk keyboard start of the week, saw DJ Shadow weds, Randall last night (support was better though). Anyhow! 🤜🤘)

Maybe a sensible ordered set of double/triple modifier hotkeys could cover all fractions for all decks for a potential addition to the defaults?

@FrankwaP FrankwaP closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants