feat: add additional BPM control options for more precise adjustments #12941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
requested changes
Mar 8, 2024
| @@ -243,6 +243,12 @@ ControlPickerMenu::ControlPickerMenu(QWidget* pParent) | |||
| addDeckAndSamplerControl("bpm_up_small", tr("BPM +0.1"), tr("Increase BPM by 0.1"), pBpmMenu); | |||
| addDeckAndSamplerControl("bpm_down_small", tr("BPM -0.1"), tr("Decrease BPM by 0.1"), pBpmMenu); | |||
| addDeckAndSamplerControl("bpm_tap", tr("BPM Tap"), tr("BPM tap button"), pBpmMenu); | |||
| addDeckAndSamplerControl("beats_set_halve", tr("BPM Halve"), tr("BPM halve"), pBpmMenu); | |||
There was a problem hiding this comment.
Suggested change
| addDeckAndSamplerControl("beats_set_halve", tr("BPM Halve"), tr("BPM halve"), pBpmMenu); | |
| addDeckAndSamplerControl("beats_set_halve", tr("BPM Halve"), tr("Multiply current BPM with 0.5"), pBpmMenu); |
etc.
There was a problem hiding this comment.
Taking a second look, I think it would be better to have the actions descried like the occur in the track menu
halve - 2/3 - 3/4 - 4/3 - 3/2 - double
mixxx/src/widget/wtrackmenu.cpp
Line 454 in 3aa73fd
ronso0
requested changes
Mar 24, 2024
| @@ -243,6 +243,12 @@ ControlPickerMenu::ControlPickerMenu(QWidget* pParent) | |||
| addDeckAndSamplerControl("bpm_up_small", tr("BPM +0.1"), tr("Increase BPM by 0.1"), pBpmMenu); | |||
| addDeckAndSamplerControl("bpm_down_small", tr("BPM -0.1"), tr("Decrease BPM by 0.1"), pBpmMenu); | |||
| addDeckAndSamplerControl("bpm_tap", tr("BPM Tap"), tr("BPM tap button"), pBpmMenu); | |||
| addDeckAndSamplerControl("beats_set_halve", tr("BPM Halve"), tr("BPM halve"), pBpmMenu); | |||
There was a problem hiding this comment.
Taking a second look, I think it would be better to have the actions descried like the occur in the track menu
halve - 2/3 - 3/4 - 4/3 - 3/2 - double
mixxx/src/widget/wtrackmenu.cpp
Line 454 in 3aa73fd
|
Integrated into #12934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12934