fixup! feat: ScopedTimer ctor accept QString::arg-compatible format…

…string
mixxxdj · May 14, 2024 · c94babc · c94babc
1 parent ededc5d
commit c94babc
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/util/timer.h b/src/util/timer.h
@@ -61,19 +61,20 @@ class ScopedTimer {
     /// @param key The format string for the key
     /// @param args The arguments to pass to the format string
     template<typename... Ts>
-    ScopedTimer(Stat::ComputeFlags compute, QString key, Ts&&... args)
+    ScopedTimer(Stat::ComputeFlags compute, const QString& key, Ts&&... args)
             : m_timer(std::nullopt) {
         if (CmdlineArgs::Instance().getDeveloper()) {
+            QString assembledKey = key;
             if constexpr (sizeof...(args) > 0) {
                 // only try to call QString::arg when we've been given parameters
                 key = key.arg(std::forward<Ts>(args)...);
             }
-            m_timer = std::make_optional<Timer>(key, compute);
+            m_timer = std::make_optional<Timer>(assembledKey, compute);
             m_timer->start();
         }
     }
     template<typename... Ts>
-    ScopedTimer(QString key, Ts&&... args)
+    ScopedTimer(const QString& key, Ts&&... args)
             : ScopedTimer(kDefaultComputeFlags, key, std::forward<Ts>(args)...) {
     }
     // for lazy users that don't wrap the key in a QStringLiteral(...)