Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RESP #6

Closed
wants to merge 2 commits into from
Closed

Use RESP #6

wants to merge 2 commits into from

Conversation

dixyes
Copy link

@dixyes dixyes commented Jun 28, 2023

闭着眼改的,没测过

@onanying
Copy link
Member

onanying commented Jun 29, 2023

这是干啥的? 对于 sub 的场景,根本不需要其他格式啊?这个库只做sub!

@dixyes
Copy link
Author

dixyes commented Jun 30, 2023

这是干啥的? 对于 sub 的场景,根本不需要其他格式啊?这个库只做sub!

理论上是这样的 但存在这么个问题 云服务商提供的托管redis服务,为了高可用会在前面套一层代理,这个代理实现的好的是支持inline commands的,然而事实是我们遇到了不支持inline command/支持有问题的(疑似#4)情况,这种情况只能用RESP

@onanying
Copy link
Member

onanying commented Jul 3, 2023

@dixyes 具体是哪个云?可以说一下么

@dixyes
Copy link
Author

dixyes commented Jul 3, 2023

@dixyes 具体是哪个云?可以说一下么

https://www.volcengine.com

@onanying
Copy link
Member

onanying commented Jul 3, 2023

还有一个问题,向下兼容么?

@dixyes
Copy link
Author

dixyes commented Jul 3, 2023

还有一个问题,就是不向下兼容了

向前兼容的,它没有改动给上层用户的接口

CRLF那个改动就是顺手写的,不是很重要,可以去掉

@onanying
Copy link
Member

onanying commented Jul 3, 2023

CRLF那个改动就是顺手写的,不是很重要,可以去掉

我的意思是:volcengine 以外的其他正常的redis,或者本地自己部署的单机redis,是不是就无法使用了?

@dixyes
Copy link
Author

dixyes commented Jul 3, 2023

不会啊 RESP是redis的标准协议

你用的这种直接tcp发命令的叫做inline commands 官方说他是“如果没有redis-cli,可以使用telnet,在交互会话中”使用的协议

很明显 RESP的支持更为广阔

@onanying
Copy link
Member

onanying commented Jul 5, 2023

@dixyes 你能帮忙提交PR到主仓库么,这是个克隆副仓库,See: mix-php/mix#91

@dixyes
Copy link
Author

dixyes commented Jul 12, 2023

@dixyes 你能帮忙提交PR到主仓库么,这是个克隆副仓库,See: mix-php/mix#91

@onanying 稍晚一些 我们在生产上验证一下 验证完成了我再往那边pr吧

@dixyes
Copy link
Author

dixyes commented Feb 5, 2024

在生产上验证过一段时间了

新的pr: mix-php/mix#129

@dixyes dixyes closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants