-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
27 current logic to quit game causes simharness vectorized environment setup to crash #28
27 current logic to quit game causes simharness vectorized environment setup to crash #28
Conversation
14a044b
to
deebd8f
Compare
@doyled-it this PR is ready to go, please review at your leisure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There will be merge conflicts with #24, but we'll cross that bridge over there.
Makes sense - hopefully just a quick rebase will be sufficient since there are so few changes. |
This PR adds
num_active_games
class variable to thesimfire.game.Game
classsimfire/utils/layers.py
that update the retrieval of landfire tif data (used to build theLandfireLatLongBox
). The updates help ensure that if the respective output path exists but does not contain any.tif
files, the tif data will be pulled as if the directory did not exist.The addition of 2. resolves #26, which I added to this PR since it was already a very small amount of changes.