Azure blob support #273
Open
Azure blob support #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aaronlippold
commented
Jul 3, 2020
•
aaronlippold
commented
- add instructions or help on any needed setup steps on the Azure side for CORS, access, etc.
- ensure errors are captured and reported at each required and optional field so that users know what they need to fix
- clarify the name of the storage - is Azure Blog the same as an S3 bucket or is this Azure Block storage
- add unit tests
- add functional tests
- add documentation in the help or on the UX of the Nexus
added 10 commits
February 26, 2020 16:06
…ng website at non-root path
rbclark
reviewed
Jul 8, 2020
| }); | ||
|
|
||
| /** Localstorage keys */ | ||
| const local_auth_method = new LocalStorageVal<MultipleSelectObject>( |
There was a problem hiding this comment.
Instead of creating an object here and then strings for the rest of the account information, could you create an azure_auth localStorageVal and just store all these on that object?
vue.config.js
Outdated
Comment on lines
48
to
61
| config.module | ||
| .rule("fonts") | ||
| .test(/\.(ttf|otf|eot|woff|woff2)$/) | ||
| .use("url-loader") | ||
| .loader("url-loader") | ||
| .tap(options => { | ||
| options = { | ||
| // limit: 10000, | ||
| name: "./fonts/[name].[ext]", | ||
| publicPath: process.env.NODE_ENV === "production" ? "./" : "/" | ||
| }; | ||
| return options; | ||
| }) | ||
| .end(); |
There was a problem hiding this comment.
As we are working towards heimdall server 2 we need to test this change to make sure it doesn't break anything there.
vue.config.js
Outdated
| options = { | ||
| // limit: 10000, | ||
| name: "./fonts/[name].[ext]", | ||
| publicPath: process.env.NODE_ENV === "production" ? "./" : "/" |
There was a problem hiding this comment.
Is there a reason this needs to be different only for production? I'm concerned this is something we can't actually validate with our test suite since it only happens in production.
|
I think we will have to fix this
--------
Aaron Lippold
[email protected]
260-255-4779
twitter/aim/yahoo,etc.
'aaronlippold'
…On Wed, Jul 8, 2020 at 12:55 PM Robert Clark ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/global/upload_tabs/azure/AuthStepBasic.vue
<#273 (comment)>:
> +};
+
+// We declare the props separately to make props types inferable.
+const Props = Vue.extend({
+ props: {
+ auth_method: Object,
+ account_name: String,
+ connection_string: String,
+ container_name: String,
+ account_suffix: String,
+ shared_access_signature: String
+ }
+});
+
+/** Localstorage keys */
+const local_auth_method = new LocalStorageVal<MultipleSelectObject>(
Instead of creating an object here and then strings for the rest of the
account information, could you create an azure_auth localStorageVal and
just store all these on that object?
------------------------------
In vue.config.js
<#273 (comment)>:
> + config.module
+ .rule("fonts")
+ .test(/\.(ttf|otf|eot|woff|woff2)$/)
+ .use("url-loader")
+ .loader("url-loader")
+ .tap(options => {
+ options = {
+ // limit: 10000,
+ name: "./fonts/[name].[ext]",
+ publicPath: process.env.NODE_ENV === "production" ? "./" : "/"
+ };
+ return options;
+ })
+ .end();
As we are working towards heimdall server 2 we need to test this change to
make sure it doesn't break anything there.
------------------------------
In vue.config.js
<#273 (comment)>:
> @@ -45,6 +45,20 @@ module.exports = {
}
},
chainWebpack: config => {
+ config.module
+ .rule("fonts")
+ .test(/\.(ttf|otf|eot|woff|woff2)$/)
+ .use("url-loader")
+ .loader("url-loader")
+ .tap(options => {
+ options = {
+ // limit: 10000,
+ name: "./fonts/[name].[ext]",
+ publicPath: process.env.NODE_ENV === "production" ? "./" : "/"
Is there a reason this needs to be different only for production? I'm
concerned this is something we can't actually validate with our test suite
since it only happens in production.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#273 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALK42EYUI6CZXIN6ZB356DR2SQG3ANCNFSM4OP7EPMQ>
.
|
…azure-blob-support Signed-off-by: Colin Doherty <[email protected]>
Signed-off-by: Colin Doherty <[email protected]>
Signed-off-by: Colin Doherty <[email protected]>
Signed-off-by: Colin Doherty <[email protected]>
…azure-blob-support Signed-off-by: Colin Doherty <[email protected]>
changed error messages to be more user friendly fixed bug in router Signed-off-by: Colin Doherty <[email protected]>
|
Do we need this functionality in heimdall2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.