Make the external link icon look better and add it in more places (#25)

mitre · Feb 28, 2022 · 2edcb82 · 2edcb82
1 parent a3d0380
commit 2edcb82
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 8 deletions.
diff --git a/_layouts/activities.html b/_layouts/activities.html
@@ -32,7 +32,10 @@ <h1>{{ page._name }}</h1>
 
 <table id="ttable" class="table table-bordered table-hover">
     <tr>
-        <th>ATT&CK® Tactics<img class="external-icon" src="{{ site.baseurl }}/assets/img/external_link.png"/></th>
+        <th>
+            ATT&CK® Tactics
+            <img class="external-icon" style="padding-left: 1%;" src="{{ site.baseurl }}/assets/img/external_link.png"/>
+        </th>
         <th>Adversary Vulnerability Presented</th>
     </tr>
     <tbody>

diff --git a/_layouts/attack_groups.html b/_layouts/attack_groups.html
@@ -27,11 +27,15 @@ <h1>Mapping To {{ page._name }}</h1>
 <br>
 <table class="table table-bordered table-hover">
   <thead>
-        <th>ATT&CK® Technique<img class="external-icon" src="{{ site.baseurl }}/assets/img/external_link.png"/></th>
-        <th>Adversary Vulnerability</th>
-        <th>Engagement Activity</th>
-        <th>Engagement Activity Description</th>
-    </thead>
+    <tr>
+      <th style="white-space:nowrap">
+        ATT&CK® Technique<img class="external-icon" src="{{ site.baseurl }}/assets/img/external_link.png"/>
+      </th>
+      <th>Adversary Vulnerability</th>
+      <th>Engagement Activity</th>
+      <th>Engagement Activity Description</th>
+    </tr>
+  </thead>
   <tbody>
     {%- for groups in site.data.attack_groups -%}
       {%- if groups.id == page._id -%}
@@ -50,6 +54,7 @@ <h1>Mapping To {{ page._name }}</h1>
             <td>
               <a href="https://attack.mitre.org/techniques/{{ row.attack_id }}">
                 {{ row.attack_technique }}
+              </a>
             </td>
             <td>{{ row.eav }}</td>
 

diff --git a/_layouts/attack_tactics.html b/_layouts/attack_tactics.html
@@ -33,7 +33,10 @@ <h1>Mapping To {{ page._name }}</h1>
 <table class="table table-bordered table-hover">
   <thead>
   <tr>
-    <th>ATT&CK® Technique<img class="external-icon" src="{{ site.baseurl }}/assets/img/external_link.png" /></th>
+    <th style="white-space:nowrap">
+      ATT&CK® Technique
+      <img class="external-icon" src="{{ site.baseurl }}/assets/img/external_link.png"/>
+    </th>
     <th>Adversary Vulnerability</th>
     <th>Engagement Activity</th>
     <th>Engagement Activity Description</th>

diff --git a/assets/css/_layouts.scss b/assets/css/_layouts.scss
@@ -778,7 +778,7 @@ pre {
 .external-icon {
     width: to-rem(20);
     box-sizing: border-box;
-    padding-left: 10%;
+    padding-left: 4%;
     margin-top: to-rem(-5);
 }
 /******/