Release 1.126.0 #1538
Release 1.126.0 #1538
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Upgrade hugo version to 0.142.0 * Replace verbose with logLevel info * Replace verbose with logLevel info in build.sh
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
odlbot
force-pushed
the
release-candidate
branch
from
974b97b to
573b8cc
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @odlbot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the project to release version 1.126.0. It includes upgrades to various dependencies and tools, including Yarn, Node.js, Hugo, and several GitHub Actions. Additionally, it fixes an issue where milestone links were unclickable due to a carousel overlay. The changes primarily involve updating version numbers and references in configuration files and workflows.
Highlights
- Dependency Upgrades: Yarn has been upgraded from v3.8.3 to v4.6.0, and Node.js has been updated to v22.14.0. Several other dependencies, such as sass-loader, envalid, and @types/sinon, have also been updated to their latest versions.
- Tooling Updates: Hugo has been upgraded to version 0.142.0. Additionally, multiple GitHub Actions, including actions/setup-node, peaceiris/actions-hugo, peter-evans/create-or-update-comment, and nwtgck/actions-netlify, have been updated to their latest major versions.
- Bug Fix: A bug causing milestone links to be unclickable due to a carousel overlay has been resolved by adding
pointer-events: noneto the carousel controls andpointer-events: autoto the carousel control links. - Resource Fetching: The
resources.GetRemotecalls in hugo templates have been updated to usetry (resources.GetRemote)to handle errors more gracefully and provide more informative error messages.
Changelog
Click here to see the changelog
- .github/workflows/ci.yml
- Updated actions/setup-node from v3 to v4.
- .github/workflows/deploy.yml
- Updated actions/setup-node from v3 to v4.
- Updated peaceiris/actions-hugo from v2 to v3.
- Updated nwtgck/actions-netlify from v2.1 to v3.0.
- Updated peter-evans/create-or-update-comment action to v4.
- .nvmrc
- Updated Node.js version from 20.18.1 to 22.14.0.
- .yarnrc.yml
- Updated Yarn version from 3.8.3 to 4.6.0.
- RELEASE.rst
- Added release notes for version 1.126.0, detailing the upgrades and fixes included in this release.
- base-theme/layouts/partials/featured_course_cards.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching featured course information.
- Wrapped
- base-theme/layouts/partials/get_instructors.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching instructor data.
- Wrapped
- base-theme/layouts/partials/get_site_metadata.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching course data.
- Wrapped
- fields/layouts/home.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching sub-fields.
- Wrapped
- fields/layouts/subfields/single.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching sub-field data.
- Wrapped
- package.json
- Updated project version from 1.125.0 to 1.126.0.
- Updated Yarn version from 3.8.3 to 4.6.0.
- Updated @types/sinon from ^10.0.6 to ^17.0.0
- Updated concurrently from ^9.0.0 to ^6.3.0
- Updated cross-env from ^6.0.0 to ^7.0.0
- Updated envalid from ^7.3.1 to ^8.0.0
- Updated hugo-bin-extended from ^0.119.0 to ^0.142.0
- Updated inquirer from ^12.0.0 to ^8.2.5
- Updated sass-loader from ^8.0.0 to ^16.0.0
- package_scripts/build.sh
- Added
--logLevel infoto the hugo command.
- Added
- package_scripts/start.ts
- Added logLevel option to the start command and hugoServer function.
- Removed renderToDisk option from HugoServerOptions type.
- package_scripts/util.ts
- Removed verbose option from HugoOptions type.
- Added logLevel option to HugoOptions type.
- Modified hugo function to include logLevel and remove --verbose flag.
- tests-e2e/LocalOcw.ts
- Removed verbose option from hugoOptions in LocalOCW class.
- tests-e2e/fixtures.spec.ts
- Added 'ocw-ci-test-www/instructors/' to the list of fixtures.
- tests-e2e/jest/build-failures.test.ts
- Changed expect(error!.stdout).toMatch(msg) to expect(error!.stderr).toMatch(msg).
- www/assets/css/about.scss
- Fixed milestone links being unclickable due to carousel overlay by adding
pointer-events: noneto the carousel controls andpointer-events: autoto the carousel control links.
- Fixed milestone links being unclickable due to carousel overlay by adding
- www/layouts/collections/single.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching collections.
- Wrapped
- www/layouts/course-lists/single.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching course list data.
- Wrapped
- www/layouts/partials/new_course_cards.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching new course data.
- Wrapped
- www/layouts/partials/ocw_news.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching OCW news.
- Wrapped
- www/layouts/resource_collections/single.html
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching resource collections.
- Wrapped
- www/layouts/sitemap.xml
- Wrapped
resources.GetRemotewithtryto handle potential errors when fetching sitemap data from studio.
- Wrapped
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The name 'Hugo' for the static site generator was inspired by the French author Victor Hugo, known for his prolific writing and impactful works.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the version of the theme and includes various dependency updates. The changes seem straightforward and necessary for keeping the project up-to-date. However, I have a few observations regarding the release notes.
Summary of Findings
Merge Readiness
The pull request appears to be in good shape for merging. The version updates in package.json and RELEASE.rst are consistent. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
|
Netlify Deployments: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1538--ocw-next.netlify.app/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1538--ocw-next.netlify.app/search/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-course-v2-pr-1538--ocw-next.netlify.app/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
|
I took a quickly look at the milestones (#1521) on https://live-qa.ocw.mit.edu/about/ and they don't seem to be working correctly. Here's a screenshot from Firefox, but I get similar results from Chrome.
Just in case, I tried to republish ocw-www, but the pipeline failed. Maybe that's related to work in progress on the pipelines? |
ibrahimjaved12
renovate[bot]