Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to v18 #1522

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrade React to v18 #1522

wants to merge 6 commits into from

Conversation

ibrahimjaved12
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6763

Description (What does it do?)

Screenshots (if appropriate):

  • Desktop screenshots
  • Mobile width screenshots

How can this be tested?

Additional Context

@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 12:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 12:01 Inactive
Copy link

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 07:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 07:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 08:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 08:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 08:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 24, 2025 08:50 Inactive
@ibrahimjaved12 ibrahimjaved12 changed the title Upgrade React Upgrade React to v18 Feb 24, 2025
"settings": {
"react": {
"version": "16.4.0"
"version": "17.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm upgrading incrementally. From v16 to v17, and then v17 to v18.
It helps keep track of changes.

With the next commit it will be v18 across all files.

@ibrahimjaved12 ibrahimjaved12 force-pushed the ibrahim/6763/upgrade-react branch from e420d64 to a582042 Compare March 5, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants