Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the links to use MARKETING_SITE_BASE_URL #2

Merged
merged 5 commits into from
Dec 23, 2021

Conversation

asadiqbal08
Copy link

@asadiqbal08 asadiqbal08 commented Dec 21, 2021

fixes: mitodl/mitxonline#268
fixes: mitodl/mitxpro#2331

From the menu in MFE in MITx Online edX, there are a couple links that need to be updated.

Acceptance Criteria

@asadiqbal08 asadiqbal08 self-assigned this Dec 21, 2021
@asadiqbal08 asadiqbal08 removed their assignment Dec 21, 2021
@asadiqbal08
Copy link
Author

The PR change should also work for mitodl/mitxpro#2331
@Wassaf-Shahzad

@Wassaf-Shahzad Wassaf-Shahzad self-assigned this Dec 21, 2021
@Wassaf-Shahzad
Copy link

The PR change should also work for mitodl/mitxpro#2331 @Wassaf-Shahzad

LGTM, however we should also update the package.json for releasing to npm

Copy link

@Wassaf-Shahzad Wassaf-Shahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes regarding the Marketing URL are good to go. However we should probably update the package.json for the npm registry

@Wassaf-Shahzad Wassaf-Shahzad added Waiting on Author waiting on author and removed Needs Review labels Dec 21, 2021
@asadiqbal08
Copy link
Author

@Wassaf-Shahzad Sorry I did not get your point, what are the changes expected to do in package.json and why ?

@Wassaf-Shahzad
Copy link

@Wassaf-Shahzad Sorry I did not get your point, what are the changes expected to do in package.json and why ?

We basically need to do some very small changes in Package.json. Such as changing the

  • The name of the component
  • The repo url
  • The description
  • The author
  • The homepage URL
    as all of these point to edx currently

@asadiqbal08 asadiqbal08 added Needs Review and removed Waiting on Author waiting on author labels Dec 23, 2021
Copy link

@Wassaf-Shahzad Wassaf-Shahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadiqbal08 asadiqbal08 merged commit 7aed33d into master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open edx (maple): Incorrect links in user menu and top navigation Couple of links that need to update
2 participants