-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the links to use MARKETING_SITE_BASE_URL #2
Conversation
The PR change should also work for mitodl/mitxpro#2331 |
LGTM, however we should also update the package.json for releasing to npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes regarding the Marketing URL are good to go. However we should probably update the package.json for the npm registry
@Wassaf-Shahzad Sorry I did not get your point, what are the changes expected to do in |
We basically need to do some very small changes in Package.json. Such as changing the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes: mitodl/mitxonline#268
fixes: mitodl/mitxpro#2331
From the menu in MFE in MITx Online edX, there are a couple links that need to be updated.
Acceptance Criteria
MIT xPRO
icon in the upper leftDashboard
linkProfile
linkAccount
linkSettings
Order History
linkSign Out
link