-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Pollard hashes up to populated nodes, not all the way to roots #226
Open
adiabat
wants to merge
28
commits into
master
Choose a base branch
from
hashtoknown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
03a1fb9
slim down tests
adiabat 8b90d15
replace [3]node with miniTree
adiabat 9b9db11
make verifyBatchProof() a method on Pollard
adiabat 9861d9f
have verifyBatchProof() do it's own reading from the pollard,
adiabat 0e278da
slight changes to formatting and comments
adiabat 3db1d2f
change datadir path (specifies blocks, not bitcoin dir)
adiabat bb24cfd
remove some unused functions; revert proofs to still include target h…
adiabat 0835f18
structure of compact serialization / deserialization for ublocks
adiabat e0261ea
add functions for recovering leaf data from block data
adiabat d2b99ee
compact deserialization needs skiplists, so pass those along
adiabat af86dc0
obvious fix in UData SerializeCompactSize()
adiabat f24feb2
compact serialization doesn't crash; but reconstruct wants target hashes
adiabat 611dfee
remove computablePositions from ProofPositions() functions
adiabat 05f9171
compiles / fits but proof hashes don't match up
adiabat 1ffe55a
remove stateless reconstruct / verify of block proofs
adiabat 0fa6964
remove redundant functions from pollard
adiabat 9678cf6
get rid of pollard full
adiabat 72fe405
add comments about changes to IngestBatchProof()
adiabat 8bb472d
add better printfs for debugging
adiabat 248d86b
make tests compile (they don't pass)
adiabat 4739809
aha the test is now wrong
adiabat 939f692
start rewrite of ingest
adiabat 337c75a
building ingestAndCheck but need to change grabPos
adiabat a015047
revert grabPos, new function to build 2d slice like ProofPositions bu…
adiabat 2e152f4
add notes
adiabat 86c7ad0
more notes on ways to change blockproofs
adiabat a4b40e6
add proofPositions2
adiabat 4f64761
add notes about hashing to known
adiabat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blockhash is not yet being restored right? at least i can't find it in any of the commits.
This also assumes a height to blockhash index on the client side exists, might not be worth it if the saving aren't huge.