Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use SFX/MFX/EFX #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

john-peterson
Copy link
Member

because it doesn't work

communication streams don't call mfx

we have to use gfx instead of mfx for post-mix because communication streams don't call mfx, they only call efx

http://download.microsoft.com/download/7/C/1/7C1C33EC-748A-477D-B250-6D90A0E0AA08/Lync%20and%20Skype%20Audio%20Offloading%20of%20Digital%20Signal%20Processing%20Effects%20in%20Windows%208-1.pdf

In Windows 8.1, a render audio stream opened in communications category is always opened in raw mode. Any must-have effect, such as speaker protection, must be implemented as an endpoint effect (EFX), which is an always-on effect.

by disabling sfx/mfx/efx everything fall back to lfx/gfx. including modern skype

better than using sfx/mfx/efx

this is better than using sfx/mfx for pre-mix and efx for post-mix because

  • the sfx/mfx/efx result is identical at best to lfx/gfx because EqualizerAPO dont use any APOInitSystemEffects2 features

  • we don't know which of sfx/mfx/efx are pre-mix and post-mix because there's almost no docs or samples for it. capture devices have no gfx. we don't know which of sfx/mfx/efx it has

  • sfx or mfx for pre-mix together with efx for post-mix fail. the audio playback is silent and create this endless Initialize loop https://www.dropbox.com/s/ghrh2ij0di3wd8m/EqualizerAPO.log?dl=0. my config.txt is

    Preamp: -30 dB
    

svn commit

commit in svn with

curl https://github.com/mirror/equalizerapo/pull/1.diff > patch.diff
patch -p1 < patch.diff

copy the commit message from https://github.com/mirror/equalizerapo/pull/1/commits

set me as author so my commit can be associated with my account here and at openhub.net

svn propset --revprop svn:author 'John Sebastian Peterson <[email protected]>'

merge my patch

i created a pull request at #1

sourceforge notification

a pull request notification is at https://sourceforge.net/p/equalizerapo/tickets/3/

@john-peterson john-peterson force-pushed the efx branch 2 times, most recently from 9384184 to 505a59a Compare February 1, 2015 08:25
@john-peterson john-peterson changed the title Add efx. Remove sfx and mfx Replace MFX with EFX Feb 1, 2015
@john-peterson john-peterson changed the title Replace MFX with EFX Don't use SFX and MFX Feb 1, 2015
@john-peterson john-peterson force-pushed the efx branch 3 times, most recently from 8305294 to 172836f Compare February 1, 2015 10:15
@john-peterson john-peterson changed the title Don't use SFX and MFX Don't use SFX/MFX/EFX Feb 1, 2015
@john-peterson john-peterson force-pushed the efx branch 6 times, most recently from 6531abe to faf7b51 Compare February 1, 2015 11:35
because it doesn't work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant