Pitch contour sonification supports nans #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objection to merging this? |
|
Looks good, thanks! |
bmcfee
added a commit
to bmcfee/mir_eval
that referenced
this pull request
May 9, 2024
craffel
pushed a commit
that referenced
this pull request
May 13, 2024
* hacking toward display revisions, not yet finished but want to test on old builds before moving forward * fixed #332, pitch contour sonification supports nans (#379) * fixing up test fixtures * correcting fixture names and paths for display * fixing separation * toward a working implementation of axes weakkeydict storage * updated mpl regression tests for labeled intervals * fixing up ticks and margins * updated hierarchy fixtures * revised separation display to use property cyclers * working through some matplotlib hackery * almost done modernizing mpl code... * very nearly done modernizing * docs and styling * rewrote segments to use axvspans * blacked tests * skip segment with text plot tests on old matplotlib * blacked tests * skip certain tests when using old versions of freetype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
This PR works be replacing nan-values by 0 in the frequency array prior to interpolation, thereby replicating the existing logic for unvoicing certain frames.
This now lets us use nan to represent unvoiced frames, which is the default behavior for (eg) librosa's pyin implementation.
I don't think we need specific additional tests here, as the change is minimal and pretty obvious when you see it.