Skip to content

Commit

Permalink
Bug 14649: Fix regression - display fund name on budget planning
Browse files Browse the repository at this point in the history
A patch from bug 11714 removes 'budget_name_indent', which was useless.
The script and the template should use the budget_name value.

Note that this patch impacts the CSV export, which does not work, so it cannot be
tested.

Test plan:
Edit a fund and click on one of the Planning value (by months, etc.)
The "Fund name" column should be correctly populated with the fund
names.

Signed-off-by: Fridolin Somers <[email protected]>
Signed-off-by: Chris Cormack <[email protected]>

Signed-off-by: Katrin Fischer <[email protected]>
Signed-off-by: Tomas Cohen Arazi <[email protected]>
  • Loading branch information
joubu authored and tomascohen committed Sep 7, 2015
1 parent 658e787 commit e0ed9cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions admin/aqplan.pl
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@

%budget_line = (
lines => \@cells_line,
budget_name_indent => $budget->{budget_name_indent},
budget_name => $budget->{budget_name},
budget_amount => $budget->{budget_amount},
budget_alloc => $budget->{budget_alloc},
budget_act_remain => sprintf( "%.2f", $budget_act_remain ),
Expand Down Expand Up @@ -448,8 +448,7 @@ sub _print_to_csv {
print "$str\n";

foreach my $row (@$results) {
$row->{'budget_name_indent'} =~ s/&nbsp;/ /g;
my @col = ( $row->{'budget_name_indent'}, $row->{'budget_amount'} );
my @col = ( $row->{'budget_name'}, $row->{'budget_amount'} );
my $l = $row->{'lines'};
foreach my $line (@$l) {
push @col, $line->{'estimated_amount'};
Expand Down
2 changes: 1 addition & 1 deletion koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
[% ELSE %]
<td>
[% END %]
<a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&amp;budget_id=[% budget_line.budget_id %]&amp;budget_period_id=[% budget_line.budget_period_id %]">[% budget_line.budget_name_indent %]</a></td>
<a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&amp;budget_id=[% budget_line.budget_id %]&amp;budget_period_id=[% budget_line.budget_period_id %]">[% budget_line.budget_name %]</a></td>
<td><span id="[% budget_line.budget_amount %]">[% budget_line.budget_amount | $Price %]&nbsp;</span>


Expand Down

0 comments on commit e0ed9cb

Please sign in to comment.