Bug 14330: Remove unused email_sender from sendbasket/sendshelf

The sendbasket/sendshelf scripts and templates do not use email_sender as a cgi parameter or as a template var. Probably a leftover from previous changes. Let's make Koha cleaner :) Test plan: [1] Send your cart from opac or staff. [2] Send a shelf from opac or staff. [3] Git grep email_sender. No results. Followed test plan. Works as expected. Signed-off-by: Marc Véron <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> Signed-off-by: Tomas Cohen Arazi <[email protected]>
minusdavid · Jun 8, 2015 · 0114465 · 0114465
1 parent 34fe5c2
commit 0114465
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 6 deletions.
diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
@@ -46,7 +46,6 @@
 
 my $bib_list     = $query->param('bib_list');
 my $email_add    = $query->param('email_add');
-my $email_sender = $query->param('email_sender');
 
 my $dbh          = C4::Context->dbh;
 
@@ -101,7 +100,6 @@
     my $resultsarray = \@results;
     $template2->param(
         BIBLIO_RESULTS => $resultsarray,
-        email_sender   => $email_sender,
         comment        => $comment
     );
 

diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
@@ -48,7 +48,6 @@
 
 my $bib_list     = $query->param('bib_list');
 my $email_add    = $query->param('email_add');
-my $email_sender = $query->param('email_sender');
 
 my $dbh          = C4::Context->dbh;
 
@@ -115,7 +114,6 @@
 
     $template2->param(
         BIBLIO_RESULTS => $resultsarray,
-        email_sender   => $email_sender,
         comment        => $comment,
         firstname      => $user->{firstname},
         surname        => $user->{surname},

diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
@@ -109,7 +109,6 @@
 
     $template2->param(
         BIBLIO_RESULTS => \@results,
-        email_sender   => $mail{'from'},
         comment        => $comment,
         shelfname      => $shelf[1],
         firstname      => $user->{firstname},

diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
@@ -103,7 +103,6 @@
 
     $template2->param(
         BIBLIO_RESULTS => \@results,
-        email_sender   => $mail{'from'},
         comment        => $comment,
         shelfname      => $shelf[1],
     );