Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nd 631 #402

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Nd 631 #402

merged 3 commits into from
Feb 7, 2025

Conversation

laurentb4
Copy link
Contributor

@laurentb4 laurentb4 commented Feb 7, 2025 •
edited
Loading

Removed variable as it is unused.
Copy paste error.

@laurentb4 laurentb4 requested a review from a team as a code owner February 7, 2025 15:26
sb21460
sb21460 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@sb21460 sb21460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentb4 laurentb4 merged commit a45e3d1 into main Feb 7, 2025
2 checks passed
@laurentb4 laurentb4 deleted the ND-631 branch February 7, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb21460 sb21460 sb21460 approved these changes

@dms1981 dms1981 Awaiting requested review from dms1981 dms1981 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@MatthewWhiteMoJ MatthewWhiteMoJ Awaiting requested review from MatthewWhiteMoJ MatthewWhiteMoJ is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@asifamirat00 asifamirat00 Awaiting requested review from asifamirat00 asifamirat00 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
dhcp-dns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentb4 @sb21460