Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.json:json to v20250107 #1126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.json:json 20240303 -> 20250107 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

@renovate renovate bot requested a review from a team as a code owner January 8, 2025 05:05
@MancRickster
Copy link
Contributor

No one else is using this at HMPPS yet.
[org.json]'s release log shows:
"20250107....Restore moditect in pom.xml"
but there's also a pending PR called "remove-duplicate-moditect: from pom.xml #931"
...might be a little premature to allow this through

@renovate renovate bot force-pushed the renovate-org.json-json-20250107.x branch from 0988a6c to 7601fb9 Compare January 14, 2025 13:57
@ppmg
Copy link
Contributor

ppmg commented Jan 14, 2025

No one else is using this at HMPPS yet. [org.json]'s release log shows: "20250107....Restore moditect in pom.xml" but there's also a pending PR called "remove-duplicate-moditect: from pom.xml #931" ...might be a little premature to allow this through

Sorry, hadn't seen your comment!

I managed to find some other consumers of this library in MoJ: https://github.com/search?q=org%3Aministryofjustice%20implementation(%22org.json%3Ajson&type=code - none of them have upgraded it yet to the 20250107 version, nor do they seem to have PRs up for it either, though.

Your point about the pending PR (GitHub automatically linked it to PR 931 from our repo, so will put the correct link here: stleary/JSON-java#931) is a good one, and I couldn't see any fixes in the release after the 20240303 one that should affect us either, se you're right, we might as well wait for the next release.

@renovate renovate bot force-pushed the renovate-org.json-json-20250107.x branch from 7601fb9 to 334196c Compare January 16, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants