[ESWE-1181] Fix API clients, JPA auditing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) MN API client: missing body 2) JB API client: scopes' separator 3) Error logging 4) Rename container name of local hmpps-auth (avoid conflict at Docker)
enable JPA auditing for `@CreatedDate` and `@LastModifiedDate`
rickchoijd
commented
Jan 30, 2025
Comment on lines
-27
to
+29
| container_name: hmpps-auth | ||
| container_name: integration-hmpps-auth |
There was a problem hiding this comment.
rename container for avoiding name clash to hmpps-auth instance (standalone at 9090)
| import org.springframework.data.jpa.repository.config.EnableJpaAuditing | ||
|
|
||
| @Configuration | ||
| @EnableJpaAuditing |
There was a problem hiding this comment.
enable JPA auditing for audit fields (create and last updated timestamps)
There was a problem hiding this comment.
add client logging for troubleshooting, disabled by default.
enable this by setting api.client.logging.enabled to true, when needed
Comment on lines
+31
to
+33
| .onErrorResume(WebClientResponseException.NotFound::class.java) { error -> | ||
| val errorResponse = if (error is WebClientResponseException) error.responseBodyAsString else null | ||
| log.warn("Employer not found. employerId={}; errorResponse={}", id, errorResponse) |
There was a problem hiding this comment.
error logging - write down the error response, if any
Comment on lines
+32
to
+34
| .onErrorResume { error -> | ||
| val errorResponse = if (error is WebClientResponseException) error.responseBodyAsString else null | ||
| Mono.error(Exception("Fail to create employer! errorResponse=$errorResponse", error)) |
There was a problem hiding this comment.
error logging - write down the error response, if any
|
|
||
| logging.level: | ||
| uk.gov.justice.digital.hmpps.jobsboardintegrationapi: | ||
| shared.infrastructure: DEBUG |
There was a problem hiding this comment.
set this to TRACE for troubleshooting
| logging.level: | ||
| uk.gov.justice.digital.hmpps.jobsboardintegrationapi: | ||
| shared.infrastructure: DEBUG | ||
| reactor.netty.http.client: INFO |
There was a problem hiding this comment.
set this to DEBUG for troubleshooting
gbmojo
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix API clients
hmpps-auth(avoid conflict at Docker)Fix JPA auditing
@CreatedDateand@LastModifiedDate