Add evaluation_failure_message to ruletypes

[teodor-yanev]

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

This PR adds a new evaluation_failure_message field to our ruletypes.

Fixes #4348

Change Type

Mark the type of change your PR introduces:

• Bug fix (resolves an issue without affecting existing features)
• Feature (adds new functionality without breaking changes)
• Breaking change (may impact existing functionalities or require documentation updates)
• Documentation (updates or additions to documentation)
• Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

• Reviewed my own code for quality and clarity.
• Added comments to complex or tricky code sections.
• Updated any affected documentation.
• Included tests that validate the fix or feature.
• Checked that related changes are merged.

[coveralls]

coverage: 53.507% (-0.002%) from 53.509%
when pulling c3c9e61 on add-evaluation_failure_message-to-ruletypes
into 15955f7 on main.

[eleftherias]

Not blocking, but we had discussed renaming evaluation_failure_message to short_failure_message to more clearly differentiate it from the long details message in https://github.com/stacklok/minder-stories/issues/3

[teodor-yanev]

Not blocking, but we had discussed renaming evaluation_failure_message to short_failure_message to more clearly differentiate it from the long details message in stacklok/minder-stories#3

Tanks for letting me know, I've renamed the components.

[eleftherias]

When I tried this out locally and set short_failure_message: This is a failure message in one of my rules, I still saw the default short message in the DB.

It's possible I'm doing something wrong, I'm going to test it again to verify.

[eleftherias]

Thanks, I'm not sure what I was doing wrong, but it was definitely me doing something wrong because it works now.