Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smaps estimation module in mri-nufft #90
Smaps estimation module in mri-nufft #90
Changes from 26 commits
f997f54
2870cc9
04773f2
23b1f61
a1966eb
ab337db
db0669e
e13948d
c817c91
6f4280a
e4fe153
33ff82a
65c6bf7
ebd8d32
f79ffad
238b358
c17ad55
dd2cf1d
506bce6
2a62f94
c1dabee
ed4d974
f6596c9
dbb7743
f138ee7
3c27e7f
d662498
8ca012c
3a980c2
093edfb
f8a6a4a
74c1ecd
0250aa8
060a8bd
aecb844
3130bc1
bc014b8
0cc73c4
21e090f
6869a4a
d77c3a0
f8364d4
67ff56a
7afdd8e
140921e
90bf832
ae50a8e
2013cf1
e7f27ea
064f9c1
7de40f6
238ec00
a58962c
ebd61d3
c0aa0c5
45bc400
18f5b34
0639eda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to check, but I think it's a new dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some copy paste error to correct (smaps instead of density compensation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that you have the SOS available as well in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do I mention though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring should be fine. Maybe rename it as
_SOS
, it's not something that users should rely onto, as it is not always available. If we want to expose it we could use a property wrapping around it (and compute the SOS on the fly when this method is not used). Somethink like: