A major bug in NSP read trajectory implementation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting here that the issue mostly affects center-out trajectories adversly |
chaithyagr
changed the title
|
good catch ! you might want to lint your code however ;) |
|
I just thought i did xD didnt commit damn it. |
|
We might want to test this use case, which is very common. Possibly add a test which reads an interpolated trajectory and compare if the interpolation matches to what we expect |
|
This is bizzare, I thought this was merged! @paquiteau any idea how we missed this, can I merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has wide implications. Bascially when OSF>1 (which is usually the case), for the first 0, 1, ... OSF points for each shot, we end up with bad k-space trajectory location which is wrong!