Display 3D trajectories, with a grid interface #193
Conversation
This add "get_interpolators_from_fieldmap", supporting both real (B0 map only) and complex (Zmap = R2* + 1j * B0map) fields in arbitrary dimension (2D and 3D). The routine supports both numpy / cupy arrays and torch tensors on CPU and GPU, the latter requiring cupy due to limitations in torch.histogram / torch.histogramdd (pytorch/pytorch#69519). Calculation uses time segmentation with uniform time samples and LS coefficients (using histogram). Based on MIRT (https://github.com/JeffFessler/mirt/blob/main/mri/mri_exp_approx.m) and its Python porting from MIRTORCH (https://github.com/guanhuaw/MIRTorch/blob/master/mirtorch/linear/mri.py) and SigPy (https://github.com/mikgroup/sigpy/blob/main/sigpy/mri/util.py).
In addition, add off-resonance example.
Avoid torch cuda test case if cupy is not available.
remove deprecated get_grad Co-authored-by: Chaithya G R <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Co-authored-by: Guillaume Daval-Frérot <[email protected]>
|
test |
1 similar comment
|
test |
|
test |
|
@Daval-G I think we can merge if you are happy... I seemed to have tagged a random person in my commit :P |
There was a problem hiding this comment.
Approved with still a few small comments to take into account, I trust that you can handle them without further review.
A few quick questions:
- The documentation wasn't generated in the latest commits, is it normal ?
- Is it a common practice to use commit messages as regular messages/comments and ping people in them ? (particularly strangers xD) Maybe let's stick to github comments
Also please read also the previous comments that are still open
| ====================== | ||
| 3D Trajectory display | ||
| ====================== |
There was a problem hiding this comment.
Please don't mark general comments as resolved as an assignee, it's difficult for reviewers if they have to look into each solved comment just to be sure it was really solved or simply to read the assignee's answer
[docs] final updates Co-authored-by: Guillaume Daval-Frérot <[email protected]>
Yes, docs is built only if we add
Its not common, I tried it, but it seems like its a bad idea |
No description provided.