Remove internal GCD function, check Real instead of Numbers

src/mrinufft/trajectories/maths.py

@@ -3,7 +3,6 @@
 import numpy as np
 import numpy.linalg as nl
 
-
 CIRCLE_PACKING_DENSITY = np.pi / (2 * np.sqrt(3))
 
 
@@ -12,26 +11,6 @@
 ##########
 
 
-def compute_greatest_common_divider(p, q):
-    """Compute the greatest common divider of two integers p and q.
-
-    Parameters
-    ----------
-    p : int
-        First integer.
-    q : int
-        Second integer.
-
-    Returns
-    -------
-    int
-        The greatest common divider of p and q.
-    """
-    while q != 0:
-        p, q = q, p % q
-    return p
-
-
 def compute_coprime_factors(Nc, length, start=1, update=1):
     """Compute a list of coprime factors of Nc.
 
@@ -54,7 +33,8 @@ def compute_coprime_factors(Nc, length, start=1, update=1):
     count = start
     coprimes = []
     while len(coprimes) < length:
-        if compute_greatest_common_divider(Nc, count) == 1:
+        # Check greatest common divider (gcd)
+        if np.gcd(Nc, count) == 1:
             coprimes.append(count)
         count += update
     return coprimes

src/mrinufft/trajectories/utils.py

@@ -1,10 +1,9 @@
 """Utility functions for the trajectory design."""
 
-import numbers as nb
-import numpy as np
-
 from enum import Enum, EnumMeta
+from numbers import Real
 
+import numpy as np
 
 #############
 # CONSTANTS #
@@ -468,7 +467,7 @@ def initialize_tilt(tilt, nb_partitions=1):
     Tilts
 
     """
-    if isinstance(tilt, nb.Number):
+    if isinstance(tilt, Real):
         return tilt
     elif tilt is None or tilt == Tilts.NONE:
         return 0
@@ -499,7 +498,7 @@ def initialize_spiral(spiral):
     float
         Spiral power value.
     """
-    if isinstance(spiral, nb.Number):
+    if isinstance(spiral, Real):
         return spiral
     return Spirals[spiral]
 
@@ -517,6 +516,6 @@ def initialize_shape_norm(shape):
     float
         Shape p-norm value.
     """
-    if isinstance(shape, nb.Number):
+    if isinstance(shape, Real):
         return shape
     return NormShapes[shape]