Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterator mismatch when alter alias and database(#2555) #2568

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pymilvus/client/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
DEFAULT_CONSISTENCY_LEVEL = ConsistencyLevel.Bounded
DEFAULT_RESOURCE_GROUP = "__default_resource_group"
REDUCE_STOP_FOR_BEST = "reduce_stop_for_best"
COLLECTION_ID = "collection_id"
GROUP_BY_FIELD = "group_by_field"
ITERATOR_FIELD = "iterator"
PAGE_RETAIN_ORDER_FIELD = "page_retain_order"
Expand Down
10 changes: 10 additions & 0 deletions pymilvus/client/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from . import __version__, blob, check, entity_helper, ts_utils, utils
from .check import check_pass_param, is_legal_collection_properties
from .constants import (
COLLECTION_ID,
DEFAULT_CONSISTENCY_LEVEL,
GROUP_BY_FIELD,
ITERATOR_FIELD,
Expand Down Expand Up @@ -861,6 +862,10 @@ def search_requests_with_expr(
if is_iterator is not None:
search_params[ITERATOR_FIELD] = is_iterator

collection_id = kwargs.get(COLLECTION_ID)
if collection_id is not None:
search_params[COLLECTION_ID] = str(collection_id)

group_by_field = kwargs.get(GROUP_BY_FIELD)
if group_by_field is not None:
search_params[GROUP_BY_FIELD] = group_by_field
Expand Down Expand Up @@ -1145,6 +1150,11 @@ def query_request(
consistency_level=kwargs.get("consistency_level", 0),
expr_template_values=cls.prepare_expression_template(kwargs.get("expr_params", {})),
)
collection_id = kwargs.get(COLLECTION_ID)
if collection_id is not None:
req.query_params.append(
common_types.KeyValuePair(key=COLLECTION_ID, value=str(collection_id))
)

limit = kwargs.get("limit")
if limit is not None:
Expand Down
1 change: 1 addition & 0 deletions pymilvus/orm/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
EF = "ef"
IS_PRIMARY = "is_primary"
REDUCE_STOP_FOR_BEST = "reduce_stop_for_best"
COLLECTION_ID = "collection_id"
ITERATOR_FIELD = "iterator"
DEFAULT_MAX_L2_DISTANCE = 99999999.0
DEFAULT_MIN_IP_DISTANCE = -99999999.0
Expand Down
15 changes: 15 additions & 0 deletions pymilvus/orm/iterator.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
CALC_DIST_JACCARD,
CALC_DIST_L2,
CALC_DIST_TANIMOTO,
COLLECTION_ID,
DEFAULT_SEARCH_EXTENSION_RATE,
EF,
FIELDS,
Expand Down Expand Up @@ -72,11 +73,14 @@ def __init__(
) -> QueryIterator:
self._conn = connection
self._collection_name = collection_name
self.__set_up_collection_id()
self._output_fields = output_fields
self._partition_names = partition_names
self._schema = schema
self._timeout = timeout
self._kwargs = kwargs
self._kwargs[ITERATOR_FIELD] = "True"
self._kwargs[COLLECTION_ID] = self._collection_id
self.__check_set_batch_size(batch_size)
self._limit = limit
self.__check_set_reduce_stop_for_best()
Expand All @@ -87,6 +91,10 @@ def __init__(
self.__seek()
self._cache_id_in_use = NO_CACHE_ID

def __set_up_collection_id(self):
res = self._conn.describe_collection(self._collection_name)
self._collection_id = res[COLLECTION_ID]

def __check_set_reduce_stop_for_best(self):
if self._kwargs.get(REDUCE_STOP_FOR_BEST, True):
self._kwargs[REDUCE_STOP_FOR_BEST] = "True"
Expand Down Expand Up @@ -336,11 +344,14 @@ def __init__(
"timeout": timeout,
"round_decimal": round_decimal,
}
self._collection_name = collection_name
self._expr = expr
self.__check_set_params(param)
self.__check_for_special_index_param()
self._kwargs = kwargs
self.__set_up_iteration_states()
self.__set_up_collection_id()
self._kwargs[COLLECTION_ID] = self._collection_id
self._filtered_ids = []
self._filtered_distance = None
self._schema = schema
Expand All @@ -352,6 +363,10 @@ def __init__(
self.__setup__pk_prop()
self.__init_search_iterator()

def __set_up_collection_id(self):
res = self._conn.describe_collection(self._collection_name)
self._collection_id = res[COLLECTION_ID]

def __init_search_iterator(self):
init_page = self.__execute_next_search(self._param, self._expr, False)
if len(init_page) == 0:
Expand Down
Loading