Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] ensure create_index and load_collection are fully completed #2478

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

brcarry
Copy link
Contributor

@brcarry brcarry commented Dec 19, 2024

  • Add wait_for_creating_index, wait_for_loading_collection to ensure create_index and load_collection are fully completed

…leted

- Add `wait_for_creating_index`, `wait_for_loading_collection` to ensure `create_index` and `load_collection` are fully completed

Signed-off-by: Ruichen Bao <[email protected]>
…tion

- Move check for channel ready and identifier interceptor setup before each query call instead of during the AsyncClient connection initialization

Signed-off-by: Ruichen Bao <[email protected]>
@czs007
Copy link
Contributor

czs007 commented Dec 20, 2024

/approve
/lgtm

@czs007
Copy link
Contributor

czs007 commented Dec 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brcarry, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8aa6de4 into milvus-io:2.5 Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants