Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.4] asyncio support #2459

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: [2.4] asyncio support #2459

merged 1 commit into from
Dec 17, 2024

Conversation

brcarry
Copy link
Contributor

@brcarry brcarry commented Dec 17, 2024

  • Support async delete, get, insert, query, search, hybrid_search, upsert, create_collection, drop_collection, describe_collection
  • Support adding interceptor to aio channel
  • Use _async_channel.channel_ready() in _wait_for_channel_ready instead of polling logic by _async_channel.get_state()
  • Add _async parameter in connections.py to determine whether to establish a synchronous or asynchronous connection
  • Update __init__.py to allow importing AsyncMilvusClient
  • Add a simple code example for AsyncMilvusClient

Signed-off-by: Ruichen Bao [email protected]

- Support async delete, get, insert, query, search, hybrid_search, upsert, create_collection, drop_collection, describe_collection
- Support adding interceptor to aio channel
- Use `_async_channel.channel_ready()` in `_wait_for_channel_ready` instead of polling logic by `_async_channel.get_state()`
- Add `_async` parameter in `connections.py` to determine whether to establish a synchronous or asynchronous connection
- Update `__init__.py` to allow importing AsyncMilvusClient
- Add a simple code example for AsyncMilvusClient

Signed-off-by: Ruichen Bao <[email protected]>
@czs007
Copy link
Contributor

czs007 commented Dec 17, 2024

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brcarry, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 239c7b0 into milvus-io:2.4 Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants