Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update proto version to latest #1958

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

zhengbuqian
Copy link
Collaborator

mainly to make sure pymilvus can have access to sparse related protos

issue: milvus-io/milvus#29419

@zhengbuqian
Copy link
Collaborator Author

Note that other than proto submodule commit update and generated files change, this PR also updates pymilvus/grpc_gen/python_gen.sh, as we introduced a new rg.proto file to milvus-proto repo

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6086d5c into milvus-io:master Mar 11, 2024
9 checks passed
@zhengbuqian zhengbuqian deleted the update-proto branch March 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants