fix: [GoSDK] Return role without grants #40284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#40274 Previousy DescribeRole returns only roles with grants, this PR add select role action to check role existence. Also added database properties related option Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
|
@congqixia E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40284 +/- ##
========================================
Coverage 80.54% 80.54%
========================================
Files 1474 1475 +1
Lines 206890 207202 +312
========================================
+ Hits 166634 166886 +252
- Misses 34211 34261 +50
- Partials 6045 6055 +10
|
|
/run-cpu-e2e |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Mar 6, 2025
Related to milvus-io#40274 Previousy DescribeRole returns only roles with grants, this PR add select role action to check role existence. Also added database properties related option --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40274
Previousy DescribeRole returns only roles with grants, this PR add select role action to check role existence.
Also added database properties related option