Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix task delta cache data race #40262

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

bigsheeper
Copy link
Contributor

issue: #40258

pr: #40259

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 February 28, 2025 06:29
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 28, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 28, 2025
@weiliu1031
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (82c000a) to head (b0f0c75).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #40262       +/-   ##
===========================================
+ Coverage   70.15%   80.89%   +10.74%     
===========================================
  Files         304     1418     +1114     
  Lines       28274   200212   +171938     
===========================================
+ Hits        19835   161962   +142127     
- Misses       8439    32570    +24131     
- Partials        0     5680     +5680     
Components Coverage Δ
Client 79.28% <ø> (∅)
Core 70.15% <ø> (ø)
Go 82.80% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/task/scheduler.go 87.31% <100.00%> (ø)

... and 1113 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 28, 2025
@czs007
Copy link
Collaborator

czs007 commented Mar 2, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 893caee into milvus-io:2.5 Mar 2, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants