Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Optimize the result format of GetQueryNodeDistribution #39664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

Use string array for SealedSegmentIDs to prevent precision loss in JSON parsers. Large integers (int64) may be incorrectly rounded when parsed as double.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 6, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (74890da) to head (673668a).
Report is 7 commits behind head on master.

❌ Your project check has failed because the head coverage (69.39%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (74890da) and HEAD (673668a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (74890da) HEAD (673668a)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39664       +/-   ##
===========================================
- Coverage   80.07%   69.39%   -10.69%     
===========================================
  Files        1465      302     -1163     
  Lines      203449    27070   -176379     
===========================================
- Hits       162918    18785   -144133     
+ Misses      34709     8285    -26424     
+ Partials     5822        0     -5822     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.39% <ø> (ø)
Go ∅ <ø> (∅)

see 1163 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 7, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Use string array for SealedSegmentIDs to prevent precision loss in JSON parsers.
Large integers (int64) may be incorrectly rounded when parsed as double.

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Feb 7, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@weiliu1031
Copy link
Contributor Author

rerun ut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants