-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Optimize the result format of GetQueryNodeDistribution #39664
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (69.39%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #39664 +/- ##
===========================================
- Coverage 80.07% 69.39% -10.69%
===========================================
Files 1465 302 -1163
Lines 203449 27070 -176379
===========================================
- Hits 162918 18785 -144133
+ Misses 34709 8285 -26424
+ Partials 5822 0 -5822
|
1ab8484
to
e6cd4ea
Compare
@weiliu1031 E2e jenkins job failed, comment |
Use string array for SealedSegmentIDs to prevent precision loss in JSON parsers. Large integers (int64) may be incorrectly rounded when parsed as double. Signed-off-by: Wei Liu <[email protected]>
e6cd4ea
to
673668a
Compare
@weiliu1031 go-sdk check failed, comment |
rerun go-sdk |
rerun ut |
Use string array for SealedSegmentIDs to prevent precision loss in JSON parsers. Large integers (int64) may be incorrectly rounded when parsed as double.