Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage v2 serializer for sync #39663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

related: #39173

Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 63.07692% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (5669016) to head (dcba33f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ernal/flushcommon/syncmgr/storage_v2_serializer.go 63.07% 21 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (63.07%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39663      +/-   ##
==========================================
+ Coverage   80.07%   80.11%   +0.03%     
==========================================
  Files        1464     1466       +2     
  Lines      203311   203494     +183     
==========================================
+ Hits       162809   163025     +216     
+ Misses      34676    34662      -14     
+ Partials     5826     5807      -19     
Components Coverage Δ
Client 79.45% <ø> (ø)
Core 69.39% <ø> (ø)
Go 81.84% <63.07%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
...ernal/flushcommon/syncmgr/storage_v2_serializer.go 63.07% <63.07%> (ø)

... and 51 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/feature Issues related to feature request from users size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants