Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bulk pack writer unstable unit test #39602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

related: #39601

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 27, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 27, 2025 04:13
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed and removed ci-passed labels Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (b3791a6) to head (a2dfed4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39602      +/-   ##
==========================================
+ Coverage   80.14%   81.74%   +1.60%     
==========================================
  Files        1465     1163     -302     
  Lines      203091   176026   -27065     
==========================================
- Hits       162762   143900   -18862     
+ Misses      34526    26318    -8208     
- Partials     5803     5808       +5     
Components Coverage Δ
Client 79.45% <ø> (ø)
Core ∅ <ø> (∅)
Go 81.84% <ø> (-0.05%) ⬇️

see 341 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants