Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cohere text embedding #39581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junjiejiangjjj
Copy link
Contributor

@junjiejiangjjj junjiejiangjjj commented Jan 24, 2025

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junjiejiangjjj
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 24, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 87.41722% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.08%. Comparing base (74890da) to head (9708cf2).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/util/function/cohere_embedding_provider.go 89.41% 6 Missing and 3 partials ⚠️
...il/function/models/cohere/cohere_text_embedding.go 81.63% 6 Missing and 3 partials ⚠️
internal/util/function/text_embedding_function.go 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39581      +/-   ##
==========================================
+ Coverage   80.07%   80.08%   +0.01%     
==========================================
  Files        1465     1467       +2     
  Lines      203449   203552     +103     
==========================================
+ Hits       162918   163022     +104     
+ Misses      34709    34700       -9     
- Partials     5822     5830       +8     
Components Coverage Δ
Client 79.45% <ø> (ø)
Core 69.39% <ø> (ø)
Go 81.81% <87.41%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/util/function/common.go 100.00% <ø> (ø)
internal/util/function/text_embedding_function.go 92.96% <94.11%> (+10.57%) ⬆️
...nternal/util/function/cohere_embedding_provider.go 89.41% <89.41%> (ø)
...il/function/models/cohere/cohere_text_embedding.go 81.63% <81.63%> (ø)

... and 27 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 6, 2025

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 6, 2025

@junjiejiangjjj E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Feb 6, 2025
Signed-off-by: junjie.jiang <[email protected]>
Copy link
Contributor

mergify bot commented Feb 6, 2025

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

@junjiejiangjjj
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Feb 6, 2025
@junjiejiangjjj
Copy link
Contributor Author

/assign @zhengbuqian @liliu-z

@zhengbuqian
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants