Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Use mockery pkg config for datacoord&datanode (#39567) #39577

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #39567
Related to #38339

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Jan 24, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby January 24, 2025 06:58
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 24, 2025
Copy link
Contributor

mergify bot commented Jan 24, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (c832793) to head (7a31736).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39577      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files        1404     1404              
  Lines      198041   198041              
==========================================
- Hits       160411   160373      -38     
- Misses      31997    32025      +28     
- Partials     5633     5643      +10     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <ø> (ø)
Go 82.94% <ø> (-0.03%) ⬇️

see 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 24, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 24, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit a48749c into milvus-io:2.5 Jan 24, 2025
19 of 20 checks passed
@congqixia congqixia deleted the cp25/39567 branch January 24, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants