Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: [cp24]Record active collections for l0Policy (#39217)" #39576

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 24, 2025

This reverts commit 79490d7.

Signed-off-by: zhenshan.cao zhenshan.cao@zilliz.com

…39217) (milvus-io#39384)"

This reverts commit 79490d7.

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Jan 24, 2025
@XuanYang-cn
Copy link
Contributor

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 24, 2025
@sre-ci-robot sre-ci-robot merged commit 08307a8 into milvus-io:hotfix-2.4.21 Jan 24, 2025
13 checks passed
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hotfix-2.4.21@6eadcac). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             hotfix-2.4.21   #39576   +/-   ##
================================================
  Coverage                 ?   80.38%           
================================================
  Files                    ?     1080           
  Lines                    ?   170130           
  Branches                 ?        0           
================================================
  Hits                     ?   136754           
  Misses                   ?    28847           
  Partials                 ?     4529           
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_l0.go 100.00% <100.00%> (ø)
internal/datacoord/compaction_trigger_v2.go 72.10% <100.00%> (ø)
internal/datacoord/services.go 84.91% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants