Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove QueryCoord's scheduling of L0 segments #39552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #39551
This PR remove querycoord's scheduling of l0 segments:

  • only load l0 segment when watch channel
  • only release l0 segment when release channel or sync data distribution

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Jan 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 91.53439% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (0bac4d3) to head (fc66423).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/delegator/delegator_data.go 83.78% 10 Missing and 2 partials ⚠️
internal/querycoordv2/dist/dist_handler.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39552       +/-   ##
===========================================
+ Coverage   69.39%   80.13%   +10.74%     
===========================================
  Files         302     1476     +1174     
  Lines       27070   204352   +177282     
===========================================
+ Hits        18785   163756   +144971     
- Misses       8285    34753    +26468     
- Partials        0     5843     +5843     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.39% <ø> (+<0.01%) ⬆️
Go 81.86% <87.63%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/index_checker.go 81.30% <ø> (ø)
internal/querycoordv2/checkers/leader_checker.go 96.83% <100.00%> (ø)
internal/querycoordv2/checkers/segment_checker.go 92.11% <100.00%> (ø)
internal/querycoordv2/meta/target_manager.go 84.37% <100.00%> (ø)
internal/querycoordv2/observers/target_observer.go 86.15% <100.00%> (ø)
internal/querycoordv2/utils/util.go 87.50% <100.00%> (ø)
internal/querynodev2/delegator/delegator.go 86.33% <100.00%> (ø)
...uerynodev2/delegator/deletebuffer/delete_buffer.go 99.20% <100.00%> (ø)
...odev2/delegator/deletebuffer/list_delete_buffer.go 100.00% <100.00%> (ø)
internal/querynodev2/delegator/delta_forward.go 68.94% <100.00%> (ø)
... and 5 more

... and 1149 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 7, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Feb 7, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants