Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refine error msg for schema & index checking #39533

Merged

Update milvus_client test case

3174acb
Select commit
Loading
Failed to load commit list.
Merged

enhance: Refine error msg for schema & index checking #39533

Update milvus_client test case
3174acb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2025 in 1s

80.91% (target 77.00%)

View this Pull Request on Codecov

80.91% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (7476eb3) to head (3174acb).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/index_service.go 50.00% 2 Missing ⚠️
internal/proxy/util.go 81.81% 2 Missing ⚠️
internal/proxy/task_index.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39533       +/-   ##
===========================================
+ Coverage   69.56%   80.91%   +11.35%     
===========================================
  Files         300     1408     +1108     
  Lines       26986   198884   +171898     
===========================================
+ Hits        18773   160932   +142159     
- Misses       8213    32249    +24036     
- Partials        0     5703     +5703     
Components Coverage Δ
Client 79.51% <ø> (∅)
Core 69.56% <ø> (-0.01%) ⬇️
Go 82.82% <68.75%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_index.go 74.61% <0.00%> (ø)
internal/datacoord/index_service.go 91.65% <50.00%> (ø)
internal/proxy/util.go 89.32% <81.81%> (ø)

... and 1106 files with indirect coverage changes